[pve-devel] [PATCH pve_flutter_frontend v4] ui: enable noVNC console on iOS
Shan Shaji
s.shaji at proxmox.com
Mon Aug 18 12:04:18 CEST 2025
Superseded by v5: https://lore.proxmox.com/pve-devel/20250818100134.30550-1-s.shaji@proxmox.com/T/#t
On Thu Aug 14, 2025 at 2:26 PM CEST, Shan Shaji wrote:
> > hi,
> >
> > thanks for sending the patch again without dart format changes (mostly,
> > see my comment on the last hunk)
> >
> > while the changes themselves look ok to me, i would have liked it more
> > for the different changes to be different patches
> >
> > e.g. adding the appbar is ok, but does not have anything to do with
> > adding ios support (that change is only a single line FWICT)
> >
> > also refactoring is also always good, but having those commits
> > separate makes it much more easy to see what is actually changed.
> >
> > aside from that, there are a few comments inline
More information about the pve-devel
mailing list