[pve-devel] [PATCH manager] ui: storage edit: warn about disabling snapshot-as-volume-chain on LVM

[Fiona Ebner]

Existing qcow2 volumes on a storage won't be handled correctly anymore
after the setting is turned off. The setting is already a fixed
storage setting for directory-based storages, so this is only relevant
for LVM. Could be improved by checking in the backend if there are any
qcow2 images and only allow turning it off if not, but this requires
changes to the on_update_hook() signature. Until then, warn in the
front-end.

Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>
---

Went with a warning rather than disallowing, so that the limitation
gets visibly communicated to the user.

 www/manager6/storage/Base.js | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/www/manager6/storage/Base.js b/www/manager6/storage/Base.js
index 84c08f2c..cf89ef6d 100644
--- a/www/manager6/storage/Base.js
+++ b/www/manager6/storage/Base.js
@@ -90,6 +90,14 @@ Ext.define('PVE.panel.StorageBase', {
             });
 
             me.advancedColumnB = me.advancedColumnB || [];
+            if (me.type === 'lvm') {
+                me.advancedColumnB.unshift({
+                    xtype: 'displayfield',
+                    name: 'external-snapshot-hint-lvm',
+                    userCls: 'pmx-hint',
+                    value: gettext('Keep Snapshots as Volume-Chain enabled if qcow2 images exist!'),
+                });
+            }
             me.advancedColumnB.unshift({
                 xtype: 'displayfield',
                 name: 'external-snapshot-hint',
-- 
2.47.2