[pve-devel] [PATCH manager 1/2] 8 to 9: lvm config: check that --clear-needs-check-flag is set if there is a thin_check_options override

[Fiona Ebner]

Quoting the commit message from [0] verbatim:

thin_check v1.0.x reveals data block ref count issue that is not being
detected by previous versions, which blocks the pool from activation if
there are any leaked blocks. To reduce potential user complaints on
inactive pools after upgrading and also maintain backward compatibility
between LVM and older thin_check, we decided to adopt the 'auto-repair'
functionality in the --clear-needs-check-flag option, rather than
passing --auto-repair from lvm.conf.

[0]: https://github.com/device-mapper-utils/thin-provisioning-tools/commit/eb28ab94

Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>
---
 PVE/CLI/pve8to9.pm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/PVE/CLI/pve8to9.pm b/PVE/CLI/pve8to9.pm
index dc3bf9ea..dcae429e 100644
--- a/PVE/CLI/pve8to9.pm
+++ b/PVE/CLI/pve8to9.pm
@@ -1796,6 +1796,32 @@ sub check_lvm_autoactivation {
     return undef;
 }
 
+sub check_lvm_thin_check_options {
+    log_info("Checking lvm config for thin_check_options...");
+
+    my $section;
+    my $detected;
+    my $detect_thin_check_override = sub {
+        my $line = shift;
+        if ($line =~ m/^(\S+) \{/) {
+            $section = $1;
+            return;
+        }
+        if ($line =~ m/thin_check_options/ && $line !~ m/--clear-needs-check-flag/) {
+            $detected = 1;
+            log_fail(
+                "detected override for 'thin_check_options' in '$section' section without"
+                    . " '--clear-needs-check-flag' option - add the option to your override (most"
+                    . " likely in /etc/lvm/lvm.conf)");
+        }
+    };
+    eval {
+        run_command(['lvmconfig'], outfunc => $detect_thin_check_override);
+        log_pass("Check for correct thin_check_options passed") if !$detected;
+    };
+    log_fail("unable to run 'lvmconfig' command - $@") if $@;
+}
+
 sub check_glusterfs_storage_usage {
     my $cfg = PVE::Storage::config();
     my $storage_info = PVE::Storage::storage_info($cfg);
@@ -2229,6 +2255,7 @@ sub check_misc {
     check_legacy_notification_sections();
     check_legacy_backup_job_options();
     check_lvm_autoactivation();
+    check_lvm_thin_check_options();
     check_rrd_migration();
     check_legacy_ipam_files();
     check_legacy_sysctl_conf();
-- 
2.47.2