[pve-devel] applied: [PATCH pve-common v2] inotify: interfaces: also set type 'bridge' for empty bridges
Fabian Grünbichler
f.gruenbichler at proxmox.com
Fri Aug 8 11:59:27 CEST 2025
On Fri, 08 Aug 2025 11:32:03 +0200, Hannes Laimer wrote:
> If a bridge has `bridge_ports` set to `none` we just skip the field.
> Later we use the existance of the field to determine whether the type
> should be `bridge`. This led to bridges without `bridge_ports` not
> being recognized as bridges.
>
> In the `/nodes/{}/network` endpiont we do permission checks for
> bridges, and if interfaces were missing the type=bridge field no
> permission checks were done. This led to interfaces being returned
> even if the user did not have permission to access them.
>
> [...]
Applied, thanks!
Added a small follow-up to make it a bit more explicit/easier to read.
[1/1] inotify: interfaces: also set type 'bridge' for empty bridges
commit: 1555ab5d76d8675e1f16a197ee744cee33200a21
Best regards,
--
Fabian Grünbichler <f.gruenbichler at proxmox.com>
More information about the pve-devel
mailing list