[pve-devel] [PATCH pve-network v2 1/1] sdn: api: always send regenerate-frr parameter

Stefan Hanreich s.hanreich at proxmox.com
Tue Aug 5 10:35:02 CEST 2025


This makes it possible to check for the definedness of the parameter
and adapt the behavior of the reloading endpoint depending on that
information. See the commit in pve-manager for more information.

Signed-off-by: Stefan Hanreich <s.hanreich at proxmox.com>
---
 src/PVE/API2/Network/SDN.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/PVE/API2/Network/SDN.pm b/src/PVE/API2/Network/SDN.pm
index 16a8e2c..af00b1a 100644
--- a/src/PVE/API2/Network/SDN.pm
+++ b/src/PVE/API2/Network/SDN.pm
@@ -93,7 +93,7 @@ my $create_reload_network_worker = sub {
     my ($nodename, $regenerate_frr) = @_;
 
     my @command = ('pvesh', 'set', "/nodes/$nodename/network");
-    push(@command, '--regenerate-frr') if $regenerate_frr;
+    push(@command, '--regenerate-frr', $regenerate_frr);
 
     # FIXME: how to proxy to final node ?
     my $upid;
@@ -299,7 +299,7 @@ __PACKAGE__->register_method({
             $lock_token,
         );
 
-        my $regenerate_frr = $previous_config_has_frr || $new_config_has_frr;
+        my $regenerate_frr = ($previous_config_has_frr || $new_config_has_frr) ? 1 : 0;
 
         my $code = sub {
             $rpcenv->{type} = 'priv'; # to start tasks in background
-- 
2.47.2




More information about the pve-devel mailing list