[pve-devel] [PATCH manager] 8 to 9 checks: warn if old udev-mac-pinning still present

[Stoiko Ivanov]

We observed this in a host which has been updated through many major
versions (at least since PVE 4). The 70-persistent-net.rules was
used keeping the NICs with 'ethX' names. With the first reboot
into trixie the NICs got their predictable names, and networking was
broken (because the 'ethX' names are not present as altname the
support for this does not help in this case)

I could not reproduce the issue with a VM (there the
70-persistent-net.rules was still active and the NIC remained ethX),
so it might be a race during early boot.

In any case a warning makes sense here as it's becoming a very niche
combination, and thus is likely to cause more issues in the future.

Suggest to manually setup pinning as suggested in our documentation:
https://pve.proxmox.com/pve-docs/pve-admin-guide.html#network_override_device_names
seems sensible.

Signed-off-by: Stoiko Ivanov <s.ivanov at proxmox.com>
---
 PVE/CLI/pve8to9.pm | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/PVE/CLI/pve8to9.pm b/PVE/CLI/pve8to9.pm
index 83f4a0c7..53ad3f10 100644
--- a/PVE/CLI/pve8to9.pm
+++ b/PVE/CLI/pve8to9.pm
@@ -2164,6 +2164,14 @@ sub check_misc {
         }
     }
 
+    my $udev_rule_file = "/etc/udev/rules.d/70-persistent-net.rules";
+    if (-f $udev_rule_file) {
+        log_warn(
+            "Old udev rules file '$udev_rule_file' for NIC-pinning found - NICs are likely to be"
+                . " renamed with newer systemd version. Replace the file with a custom"
+                . " systemd.link file.");
+    }
+
     log_info("Check node certificate's RSA key size");
     my $certs = PVE::API2::Certificates->info({ node => $nodename });
     my $certs_check = {
-- 
2.39.5