[pve-devel] [PATCH pve-manager master v1 1/1] pve8to9: check if unit 'systemd-journald-audit.socket' is active

[Max R. Carrara]

... and display a `log_notice()` to the user if it is in order to
inform them about audit messages being logged during the upgrade,
as well as suggesting that they stop and disable the unit before
the upgrade.

In Debian Bookworm and earlier, audit messages were not logged by
default [0], whereas the unit was active by default. This was changed
in between Bookworm and Trixie; the patch that changed the default was
dropped [1], whereas the unit is now disabled.

This means that the unit will remain active during the upgrade, which
will in turn cause a lot of audit message log spam.

[0]: https://salsa.debian.org/systemd-team/systemd/-/commit/07daa6196f9c92be8a0f552b1416576e80d054dc
[1]: https://salsa.debian.org/systemd-team/systemd/-/commit/7c6ea97a1d7e438e6621c3b97ce472754fd3db43

Signed-off-by: Max R. Carrara <m.carrara at proxmox.com>
---
 PVE/CLI/pve8to9.pm | 51 ++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 51 insertions(+)

diff --git a/PVE/CLI/pve8to9.pm b/PVE/CLI/pve8to9.pm
index 8c26ddbd..b5b0c8bb 100644
--- a/PVE/CLI/pve8to9.pm
+++ b/PVE/CLI/pve8to9.pm
@@ -2069,6 +2069,56 @@ sub check_legacy_ipam_files {
     }
 }
 
+sub check_journald_audit_socket {
+    my $unit = 'systemd-journald-audit.socket';
+
+    log_info("Checking whether systemd unit '$unit' is active...");
+
+    my ($res_is_enabled, $res_is_active) = (undef, undef);
+
+    eval {
+        run_command(
+            ['systemctl', 'is-enabled', "$unit"],
+            outfunc => sub {
+                ($res_is_enabled) = @_;
+                chomp $res_is_enabled;
+            },
+            noerr => 1,
+        );
+    };
+
+    eval {
+        run_command(
+            ['systemctl', 'is-active', "$unit"],
+            outfunc => sub {
+                ($res_is_active) = @_;
+                chomp $res_is_active;
+            },
+            noerr => 1,
+        );
+    };
+
+    if (!defined($res_is_enabled) || !defined($res_is_active) || $res_is_enabled eq 'not-found') {
+        log_skip("Unit '$unit' not found");
+        return undef;
+    }
+
+    my $msg =
+        "Unit '$unit' is '$res_is_enabled' and '$res_is_active' - to prevent an excessive amount of"
+        . " audit messages being logged during the upgrade, it is recommended to stop and disable"
+        . " '$unit' beforehand."
+        . "\nThis can be achieved by running the following command:"
+        . "\n\n\tsystemctl disable --now $unit\n";
+
+    if ($res_is_enabled eq 'enabled' || $res_is_active eq 'active') {
+        log_notice($msg);
+        return undef;
+    }
+
+    log_pass("Unit '$unit' is '$res_is_enabled' and '$res_is_active'");
+    return undef;
+}
+
 sub check_misc {
     print_header("MISCELLANEOUS CHECKS");
     my $ssh_config = eval { PVE::Tools::file_get_contents('/root/.ssh/config') };
@@ -2164,6 +2214,7 @@ sub check_misc {
     check_lvm_autoactivation();
     check_rrd_migration();
     check_legacy_ipam_files();
+    check_journald_audit_socket();
 }
 
 my sub colored_if {
-- 
2.39.5