[pve-devel] [PATCH ha-manager 1/2] manager: support older versioning schema for ha group migration
Daniel Kral
d.kral at proxmox.com
Mon Aug 4 16:20:53 CEST 2025
Prior to the Proxmox VE 8.x series, the pve-manager is versioned in the
format of `M.m-p`. Versions prior to Proxmox VE 8.x are already EOL'd,
but this change prevents any "Use of uninitialized value" log messages
if one of the nodes is on a version with such a versioning scheme.
Signed-off-by: Daniel Kral <d.kral at proxmox.com>
---
Missed that patch in the v2 for the follow-up for the ha-manager (but
was included in the v1).
Not really important (i.e. doesn't result in any fatal errors), but gets
rid of a "use of unitialized value" warning from perl while running the
tests/looking in the syslog in the rather unlikely (unsupported) case
that one has the CRM node running PVE 9.* and another node still running
7.4...
src/PVE/HA/Manager.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/HA/Manager.pm b/src/PVE/HA/Manager.pm
index 884d098b..ba59f642 100644
--- a/src/PVE/HA/Manager.pm
+++ b/src/PVE/HA/Manager.pm
@@ -539,7 +539,7 @@ my $have_groups_been_migrated = sub {
my $get_version_parts = sub {
my ($node_version) = @_;
- return $node_version =~ m/^(\d+)\.(\d+)\.(\d+)(?:~(\d+))?/;
+ return $node_version =~ m/^(\d+)\.(\d+)(?:\.|-)(\d+)(?:~(\d+))?/;
};
my $has_node_min_version = sub {
--
2.47.2
More information about the pve-devel
mailing list