[pve-devel] [PATCH pve-manager 1/1] api: network: default to not regenerating the frr configuration

[Stefan Hanreich]

On 8/4/25 4:10 PM, Stefan Hanreich wrote:
> On 8/4/25 4:07 PM, Thomas Lamprecht wrote:
>> Am 04.08.25 um 15:46 schrieb Stefan Hanreich:
>>> Default to not regenerating the FRR configuration, unless explicitly
>>> requested. Otherwise applying the host network configuration would
>>> reload and enable the FRR service. Invert the boolean from skip to
>>> regenerate, since the logic is less convoluted this way.
>>
>>
>> and casually break API and reloading SDN during the upgrade, while
>> triggering such updates might be not the best idea to do in the first
>> place it would be at least good to call it out here.
>>
>> FWIW, if we'd walk the full mile here we probably would keep the old
>> param as fallback and check the node version from the pmxcs in memory
>> kv store in pve-network to determine what param to send to the other
>> nodes.
>>
>> That said, I can live with skip doing that, it is a major release
>> after all. Just ensure you have upgrades on your mind or, if you had,
>> add a note for that next time.
> 
> The parameter has been introduced in PVE 9 with the SDN fabrics, so it
> should be fine to change this. Sorry, I should've at least mentioned it.

Ah sorry, I misunderstood - in PVE 8 we actually did always execute
generate_controller_config..