[pve-devel] [PATCH manager] fix #6599: ui: use font-awesome instead of png icons

[Fiona Ebner]

Am 04.08.25 um 12:50 PM schrieb Shannon Sterz:
> previously we used custom png rendered icons for guests and storages
> in the add menu of a pool, as well as for mountpoints for containers.
> these appeared blurry on high resolution displays and since they were
> just the same as the font-awesome icons anyway, use those directly.
> the ui already loads font-awesome regardless, so there are no
> down-sides here.
> 
> Signed-off-by: Shannon Sterz <s.sterz at proxmox.com>
> ---
>  www/manager6/grid/PoolMembers.js | 4 ++--
>  www/manager6/lxc/Resources.js    | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/www/manager6/grid/PoolMembers.js b/www/manager6/grid/PoolMembers.js
> index f025a1380..83046ee0e 100644
> --- a/www/manager6/grid/PoolMembers.js
> +++ b/www/manager6/grid/PoolMembers.js
> @@ -243,7 +243,7 @@ Ext.define('PVE.grid.PoolMembers', {
>                          items: [
>                              {
>                                  text: gettext('Virtual Machine'),
> -                                iconCls: 'pve-itype-icon-qemu',
> +                                iconCls: 'fa fa-desktop',
>                                  handler: function () {
>                                      var win = Ext.create('PVE.pool.AddVM', { pool: me.pool });
>                                      win.on('destroy', reload);
> @@ -252,7 +252,7 @@ Ext.define('PVE.grid.PoolMembers', {
>                              },
>                              {
>                                  text: gettext('Storage'),
> -                                iconCls: 'pve-itype-icon-storage',
> +                                iconCls: 'fa fa-hdd-o',
>                                  handler: function () {
>                                      var win = Ext.create('PVE.pool.AddStorage', { pool: me.pool });
>                                      win.on('destroy', reload);
> diff --git a/www/manager6/lxc/Resources.js b/www/manager6/lxc/Resources.js
> index 9f6df3a58..3defb8003 100644
> --- a/www/manager6/lxc/Resources.js
> +++ b/www/manager6/lxc/Resources.js
> @@ -128,7 +128,7 @@ Ext.define('PVE.lxc.RessourceView', {
>              rows[confid] = {
>                  group: group,
>                  order: i,
> -                tdCls: 'pve-itype-icon-storage',
> +                iconCls: 'hdd-o',

This changes from 'tdCls' to 'iconCls' and does not use 'fa fa-hdd-o'
like above. Is that intentional?

>                  editor: mpeditor,
>                  header: header,
>                  renderer: Ext.htmlEncode,

Can we get rid of the related CCS classes and PNG images after this change?