[pve-devel] [PATCH cluster 1/5] pmxcfs: status: add one more missing g_free

[Lukas Wagner]

On Fri Aug 1, 2025 at 11:54 AM CEST, Lukas Wagner wrote:
> Otherwise we leak the memory that was already allocated for `filename`.
>
> Signed-off-by: Lukas Wagner <l.wagner at proxmox.com>
> ---
>  src/pmxcfs/status.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/src/pmxcfs/status.c b/src/pmxcfs/status.c
> index a00e793..886d0bd 100644
> --- a/src/pmxcfs/status.c
> +++ b/src/pmxcfs/status.c
> @@ -1369,6 +1369,8 @@ static void update_rrd_data(const char *key, gconstpointer data, size_t len) {
>          } else if (g_file_test(filename_pve2, G_FILE_TEST_EXISTS)) {
>              // old file exists, use it
>              use_pve2_file = 1;
> +
> +            g_free(filename);
>              filename = g_strdup_printf("%s", filename_pve2);
>          } else {
>              // neither file exists, check for directories to decide and create file


FWIW, did a quick rebuild of pve-cluster with -fsanitize=address set in the
CFLAGS/LDFLAGS. While I might not have hit all possible code paths
during my test run, at least the "main" one with the new RRD format came back
without any reported leaks!