[pve-devel] [RFC storage 0/3] rbd: use image-/snap-spec instead of --pool/..

[Aaron Lauterer]

Tested this patch series by:

* create a new VM on ceph RBD
* took & removed snapshot (with memory)
* cloned VM
* converted to template (rename from vm-… to base-… worked)
* created linked clone
* destroy template -> fail due to linked clone
* destroy linked clone
* destroy template

namespace tests:
* create rbd namespace
* move-disk of VM to namespace (main disk, EFI, tpm)
* remote migrate from rbd namespace to other node with local-lvm
* remote migrate back from local-lvm to rbd namespace storage


The code changes look good and I didn't notice anything there.

So with this, consider this series

Reviewed-By: Aaron Lauterer <a.lauterer at proxmox.com>
Tested-By: Aaron Lauterer <a.lauterer at proxmox.com>

On  2025-04-23  15:59, Fabian Grünbichler wrote:
> the 'rbd' CLI tool has two ways of specifying which images/snapshots to
> operate on:
> - the deprecated --(dest-)pool, --namespace, --image and --snap parameters
> - the new style 'spec'-based variant, passing [pool/[namespace/]]image[@snapshot]
> 
> we are currently using a mix of both (passing pool, namespace and snap
> as needed via parameters, and the image-name as argument). this patch
> series switches everything to use image or snap specs, except for `ls`,
> which can't be switched over, because it doesn't operate on images at
> all.
> 
> `unmap` doesn't support `--namespace` (but doesn't need it, since it
> takes the kernel dev as argument). `import` doesn't either, but does
> require it when a namespace is used as import target (this bug prompted
> the whole excursion resulting in this patch series).
> 
> I smoke-tested the changes, but it's possible I missed some operation or
> corner case when converting, so additional testing is highly
> appreciated.
> 
> Fabian Grünbichler (3):
>    rbd: extend get_rbd_(dev_)path helpers with $snap parameter
>    fix #6338: rbd: use image-/snap-spec consistently
>    rbd: add protect/unprotect helpers
> 
>   src/PVE/Storage/RBDPlugin.pm | 167 ++++++++++++++++++-----------------
>   1 file changed, 86 insertions(+), 81 deletions(-)
>