[pve-devel] [PATCH pve-installer 1/6] auto: add early answer file sanity check for RAID configurations
Christoph Heiss
c.heiss at proxmox.com
Tue Apr 29 11:40:17 CEST 2025
On Tue Apr 29, 2025 at 11:32 AM CEST, Michael Köppl wrote:
> On 4/29/25 10:26, Christoph Heiss wrote:
>>>> ZFS actually lets one create RAIDZ{1,2,3} pools with 2, 3 and 4 disks,
>>>> respectively. While maybe not really _that_ practical for real-world
>>>> usecases (starting with the overhead), do we want to still allow it?
>>>
>>> I personally don't like putting too many constraints on what users can
>>> do. Even if not every setting is practical, I think the installer should
>>> allow them as long as they don't mean that the whole installation is
>>> going to crash halfway through,
>>
>> Yep, definitely. I also like to err on the side of caution and rather
>> allow more than what might be technical feasible and/or allowed - latter
>> especially w.r.t. network settings.
>>
>> I'd then just lower it to the actual allowed minimum as mentioned above,
>> doesn't hurt in any case :^)
>
> I think I'd prefer doing this in a separate series, though. Changes
> would have to be made in the installer, the UI (there's a check there as
> well when creating a ZFS pool) and, IMO, also PBS. There are checks in
> PBS as well and I don't think it's a good idea to have diverging
> behavior between PVE and PBS about what is and isn't allowed w.r.t. ZFS
> RAID setups.
I see, didn't think of all the other places where we assume this.
You can just disregard it then.
More information about the pve-devel
mailing list