[pve-devel] [PATCH qemu-server v2 6/13] api2: qemu: add module exposing node migration capabilities

[Christoph Heiss]

Thanks for the review!

On Thu Apr 24, 2025 at 2:02 PM CEST, Fiona Ebner wrote:
> Am 24.04.25 um 13:19 schrieb Christoph Heiss:
>> diff --git a/PVE/API2/Qemu/Migration.pm b/PVE/API2/Qemu/Migration.pm
>> new file mode 100644
>> index 00000000..34125a15
>> --- /dev/null
>> +++ b/PVE/API2/Qemu/Migration.pm
>> @@ -0,0 +1,46 @@
>> +package PVE::API2::Qemu::Migration;
>
> (Sorry, answered to v1 accidentally before)
>
> Would be nice to have the package name reflect that this is only for
> node-side capabilities and not the QEMU-side migration capabilities.
> Maybe PVE::API2::NodeCapabilities::Qemu::Migration?

Makes sense, in order to avoid future conflicts as mentioned below!

I'll change it with v3, probably also changing over the other node
capabilities API modules if it does not have the potential to break
anything.

>
> Otherwise, there will be a conflict if we move the other
> migration-related API endpoints into a dedicated module, because the API
> paths here and there have different parents. For that module, the name
> PVE::API2::Qemu::Migration would be most fitting.