[pve-devel] [PATCH pve-esxi-import-tools] fix #6347: do not break vm listing on invalid configs

[Daniel Herzig]

Daniel Kral <d.kral at proxmox.com> writes:

> On 4/23/25 16:04, Daniel Herzig wrote:
>>> Oops, I should have prefixed my patch with a "fix" at least, but I've
>>> sent two patches some days ago for this ;):
>>>
>>> https://lore.proxmox.com/pve-devel/20250411150634.253684-1-d.kral@proxmox.com/T/#u
>>>
>> Ha, I missed that one, you were too quick ;)
>> It turned out that the problem was on the specific ESXI-side config
>> (`vm.config` is there on ESXI-6.7.x as well, without it we could not do
>> anything anyway -- `fetch_and_update_vm_data` calls it more than
>> once inherently). But it's `None` for sure if there's an invalid vm config on the ESXI side.
>
> Thanks for the info!
>
> I was wondering why it didn't work for them (in the forum) and have
> only figured that there was something undocumented in the PyVim API
> about when the OptionType is None, but with either patch it should be
> fine now :).
>
I think so too!