[pve-devel] [PATCH pve-esxi-import-tools] fix #6347: do not break vm listing on invalid configs

Daniel Kral d.kral at proxmox.com
Wed Apr 23 15:28:45 CEST 2025


On 4/23/25 15:03, Daniel Herzig wrote:
> Move the queries for vCLS machines and empty datastore strings into
> the already existing try-except routine to save `listvms.py` from
> breaking when `vm.config` is `None`.
> 
> Do not store the result of the `any` function in a variable anymore,
> do the same for the datastore query to shorten code.
> 
> Prepare more verbose logging.
> 
> Signed-off-by: Daniel Herzig <d.herzig at proxmox.com>

Oops, I should have prefixed my patch with a "fix" at least, but I've 
sent two patches some days ago for this ;):

https://lore.proxmox.com/pve-devel/20250411150634.253684-1-d.kral@proxmox.com/T/#u

But it's also good to just extend the scope of the try-catch here 
without the additional check for whether the vm.config has a value or not.




More information about the pve-devel mailing list