[pve-devel] [PATCH container v3 06/11] alloc_disk: update vdisk_alloc optional arguments signature

Daniel Kral d.kral at proxmox.com
Tue Apr 15 15:50:40 CEST 2025


Update the call to `PVE::Storage::vdisk_alloc` to the updated function
signature, which moves the optional argument `$name` (as it may be
passed as undefined), to the optional hash argument at the end of the
argument list.

Signed-off-by: Daniel Kral <d.kral at proxmox.com>
---
changes since v2:
  * rename helper from *_supported to *_available
  * lower/remove storage_check_enabled to storage_config where possible
    due to the helper already checking that
  * change of vdisk_alloc signature with required $vtype

 src/PVE/LXC.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index 97c0fa6..4209233 100644
--- a/src/PVE/LXC.pm
+++ b/src/PVE/LXC.pm
@@ -2187,7 +2187,7 @@ sub alloc_disk {
 	    $do_format = 1;
 	}
 
-	$volid = PVE::Storage::vdisk_alloc($storecfg, $storage, $vmid, $format, undef, $size_kb);
+	$volid = PVE::Storage::vdisk_alloc($storecfg, $storage, $vmid, $format, $size_kb);
 
 	format_disk($storecfg, $volid, $root_uid, $root_gid) if $do_format;
     };
-- 
2.39.5





More information about the pve-devel mailing list