[pve-devel] [PATCH-SERIES http-server 0/3] fix disconnecting clients

[Thomas Lamprecht]

On Tue, 08 Apr 2025 16:20:11 +0200, Fiona Ebner wrote:
> Commit 07e56cc ("fix unexpected EOF for client when closing TLS
> session") added a call to stoptls() before the call to shutdown() for
> the handle's file descriptor. However, the documentation for
> AnyEvent[0] mentions for stoptls():
> 
> > This method may invoke callbacks (and therefore the handle might be
> > destroyed after it returns).
> 
> [...]

Applied, thanks!

Btw. I did some benchmarks yesterday running `oha` [0] and I rechecked the logs
and I found a handful of such error messages too that I did overlook before.
With your patches I could not see them anymore after running a 10s five times
(vs just once yesterday)

[1/3] anyevent: disconnect: check that handle is still defined before calling shutdown()
      commit: 0ec627cff14a51695e6f81f86b34b398b07cf329
[2/3] anyevent: always avoid re-entering client_do_disconnect() in on_error callback
      commit: fa639169214f679c90274e4a6f1a84b864212326
[3/3] anyevent: handle 'disconnected' flag in client_do_disconnect() itself
      commit: f82b416214c94720c04dd02d5f5778af3439187f

[0]: https://github.com/hatoo/oha