[pve-devel] [PATCH qemu-server v5 2/4] api: status/current: add display property

[Aaron Lauterer]

On  2025-04-08  09:49, Fiona Ebner wrote:
> Am 07.04.25 um 18:27 schrieb Aaron Lauterer:
>> @@ -3048,8 +3058,11 @@ __PACKAGE__->register_method({
>>   
>>   	$status->{ha} = PVE::HA::Config::get_service_status("vm:$param->{vmid}");
>>   
>> +	$status->{display}->{type} = 'std';
> 
> This is not the correct default in all cases (e.g. aarch64 VM, old
> Windows). Please use the get_vga_properties() helper from QemuServer.pm
> (you'll need to make it public by dropping its "my" of course).

Thanks! Will do

> 
>>   	if ($conf->{vga}) {
>>   	    my $vga = PVE::QemuServer::parse_vga($conf->{vga});
>> +	    $status->{display}->{type} = $vga->{type} if defined($vga->{type});
>> +
>>   	    my $spice = defined($vga->{type}) && $vga->{type} =~ /^virtio/;
>>   	    $spice ||= PVE::QemuServer::vga_conf_has_spice($conf->{vga});
>>   	    $status->{spice} = 1 if $spice;
>