[pve-devel] [PATCH manager v6 3/4] ui: qemu hd edit: allow importing a disk from the import storage

[Dominik Csapak]

On 4/8/25 10:40, Thomas Lamprecht wrote:
> Am 08.04.25 um 09:01 schrieb Dominik Csapak:
>> On 4/8/25 00:13, Thomas Lamprecht wrote:
>>> Am 07.04.25 um 12:13 schrieb Dominik Csapak:
>>>> adds a checkbox 'import image' above the storage selector which:
>>>> * hides the original storage selector
>>>> * shows a 'source storage' selector
>>>> * shows a 'import file' selector
>>>> * shows a 'target storage' selector
>>>>
>>>> Since the wizard and the hd edit share this panel, this also works in
>>>> the wizard.
>>>
>>> Can we disable this for HD Add? IMO that dialogue is already really
>>> complex as is.
>>>
>>> Might be even beneficial if this is always predefined from the call
>>> or integration side...
>>>
>>> And seems I cannot start an import through the import storage content
>>> view? Feels odd to me, all other imports are triggered there after all.
>>
>> ok so if I understand you correctly, you want this in the wizard but not
>> in the 'add hd' panel ? And you want to have a (probably simplified) hd
>> add panel from the import storage content panel directly ?
> 
> Yeah for starters I'd probably just have gone for allowing importing
> such a disk to an existing VM. That said checking a few reports and
> rethinking this users might actually want to have it available in the
> creation process, that feels a bit more natural...
> 
> Cc'in Aaron for an opinion as he often gets UX feedback a bit more
> directly in trainings and has a more decisive opinion on these
> things.

what i currently have (half) working here is basically what i wrote
below, the same input panel, but either for creating a new disk
or importing, and the caller decides. with another button in
the wizard that allows adding such an 'import panel'

(should be relatively easy to add that to the hardware panel and
import storage content too)

> 
>>
>> sounds fine to me, an alternative I could offer would be to
>> have a separate input panel only for importing, and show in the wizard
>> another button (e.g. split button on add) that adds that import panel
>> and for the guests a new entry in the 'add menu' that says 'import'
>>
>> (this panel could then also be added to the import storage content,
>> with an additional vm selector)
> 
> btw: should this have a fix #2424 ?

you're right, at least a 'partially fixes #2424' since the users also wanted to have
definitions uploaded (libvirt xmls?) but not sure if that's even a thing that we
want to have..