[pve-devel] [PATCH qemu-server v16 4/12] control: add virtiofsd as runtime dependency for qemu-server

[Markus Frank]

On  2025-04-07 14:00, Thomas Lamprecht wrote:
> Am 07.04.25 um 12:59 schrieb Markus Frank:
>> On  2025-04-07 12:43, Thomas Lamprecht wrote:
>>> Would your code handle the case where the executable does not exist
>>> with a somewhat nice error?
>> No, it does not.
>>
>> But it can easily be added.
>>    
>> diff --git a/PVE/QemuServer/Virtiofs.pm b/PVE/QemuServer/Virtiofs.pm
>> index 5b948d57..6c9018e5 100644
>> --- a/PVE/QemuServer/Virtiofs.pm
>> +++ b/PVE/QemuServer/Virtiofs.pm
>> @@ -163,6 +163,9 @@ sub start_virtiofsd {
>>        my $dir_cfg = PVE::Mapping::Dir::find_on_current_node($virtiofs->{dirid});
>>    
>>        my $virtiofsd_bin = '/usr/libexec/virtiofsd';
>> +    if (! -f $virtiofsd_bin) {
>> +       print "virtiofsd is not installed. To use virtio-fs, install virtiofsd via apt.\n";
> 
> s/print/die/, I'd think? Or at least log_warn + early return.
Yes, should be a die. My mistake.
> 
> And could you send a v17 with that changed? Maybe also the
> UI proposal from Filip (please talk with Dominik about if that
> would be fine in general)
Okay, I will do that.