[pve-devel] [PATCH widget-toolkit v3 1/1] close #3181: ui: add formatted guest identifier to safe destroy dialog window

Michael Köppl m.koeppl at proxmox.com
Mon Apr 7 10:38:05 CEST 2025


Adds a formatted guest identifier (e.g. "VMID (VM name)") to the
SafeDestroy window. The formatted identifier is only used if it is
explicitly set by the caller. Otherwise, the VMID is used, avoiding
changes in behavior for other components.

Signed-off-by: Michael Köppl <m.koeppl at proxmox.com>
---
 src/window/SafeDestroy.js | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/src/window/SafeDestroy.js b/src/window/SafeDestroy.js
index fad7897..1505870 100644
--- a/src/window/SafeDestroy.js
+++ b/src/window/SafeDestroy.js
@@ -26,6 +26,7 @@ Ext.define('Proxmox.window.SafeDestroy', {
     config: {
 	item: {
 	    id: undefined,
+	    formattedIdentifier: undefined,
 	},
 	url: undefined,
 	note: undefined,
@@ -189,7 +190,12 @@ Ext.define('Proxmox.window.SafeDestroy', {
 	let taskName = me.getTaskName();
 	if (Ext.isDefined(taskName)) {
 	    me.lookupReference('messageCmp').setHtml(
-		Ext.htmlEncode(Proxmox.Utils.format_task_description(taskName, itemId)),
+		Ext.htmlEncode(
+		    Proxmox.Utils.format_task_description(
+			taskName,
+			me.getItem().formattedIdentifier ?? itemId,
+		    ),
+		),
 	    );
 	} else {
 	    throw "no task name specified";
-- 
2.39.5





More information about the pve-devel mailing list