[pve-devel] superseded: [PATCH manager 2/5] user: password edit: clarify that password changes for PAM realm only apply to local node

[Fiona Ebner]

Am 06.04.25 um 20:01 schrieb Thomas Lamprecht:
> Am 04.12.24 um 12:37 schrieb Fiona Ebner:
>> Reported in the community forum:
>> https://forum.proxmox.com/threads/158518/
>>
>> Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>
>> ---
>>  www/manager6/dc/UserView.js | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/www/manager6/dc/UserView.js b/www/manager6/dc/UserView.js
>> index 82bd2ee7..d5844674 100644
>> --- a/www/manager6/dc/UserView.js
>> +++ b/www/manager6/dc/UserView.js
>> @@ -68,10 +68,16 @@ Ext.define('PVE.dc.UserView', {
>>  		return false;
>>  	    },
>>  	    handler: function(btn, event, rec) {
>> +		let hintHtml;
>> +		if (rec.data['realm-type'] === 'pam') {
>> +		    hintHtml = gettext("For the PAM realm, this only applies to the local node.");
> 
> I'd switch the place of `only` and `applies` and maybe s/local/connected/,
> like:
> 
> For the PAM realm, this applies only to the connected node.
> 
>> +		}
>> +
>>  		Ext.create('Proxmox.window.PasswordEdit', {
>>  		    userid: rec.data.userid,
>>  		    confirmCurrentPassword: Proxmox.UserName !== 'root at pam',
>>  		    autoShow: true,
>> +		    hintHtml: hintHtml,
> 
> FYI, if variable name and property name match, i.e., left part of the colon is
> the same as the right part, you can just use that directly, e.g. `{ hintHtml }`
> is the same as `{ hintHtml: hintHtml }`; but not something that needs to be
> used as of now, but would be fine to be used.
> 
>>  		    minLength: 8,
>>  		    listeners: {
>>  			destroy: () => reload(),
> 

Sent a v2:
https://lore.proxmox.com/pve-devel/20250407081657.23658-1-f.ebner@proxmox.com/