[pve-devel] applied: [PATCH widget-toolkit, manager v3 0/3] ui: tasks: add button to

[Thomas Lamprecht]

Am 18.11.24 um 11:45 schrieb Aaron Lauterer:
> Especially in the task-log at the bottom in PVE, users might not realize
> that they can open the task log with a double-click. By adding an action
> column with a button, this should be easier to discover.
> 
> While we are at it, let's have it in the task view panel as well. Here
> it can help save clicks for non-double-click users as they don't have to
> select and then go to the "view" button.
> 
> The tooltip is "View Task". This should leave no ambiguity in that it is
> a read-only operation. One patch aligns the button at the top of the
> task panel.
> 
> Using the "chevron-right" icon was initially done to align with how we
> do that in the pbs UI. Especially in the task panel, I stuck with it, as
> a test with the "window-open" icon, that is used in the button at the
> top, resulted in quite the visual noise IMHO.
> 
> Regarding the placement in the grids after a discussion with Dominik:
> putting the action column as first column reduces mouse travel, but is a
> rather uncommon placement. It would either be seen just as the icon, or
> an option to expand/collapse that row.
> 
> It is more common, and thus the user expectaion, to have these buttons
> rather at the end of the row.
> 
> This is why I send the patches with the action columns as the last in
> the grid. It is not the only option, one can of course double click
> anywhere on the row too.
> 
> 
> changes sinve v2:
> * add the action column to the tasks panel in the widget toolkit
> * align button in the widget toolkits tasks panel to match the tooltip
> 
> 
> widget-toolkit: Aaron Lauterer (2):
>   node tasks: add action column with button to view task
>   node tasks: align view task button label to other uses
> 
>  src/node/Tasks.js | 21 ++++++++++++++++++++-
>  1 file changed, 20 insertions(+), 1 deletion(-)
> 
> 
> manager: Aaron Lauterer (1):
>   ui: tasks: add actioncolumn to open task
> 
>  www/manager6/dc/Tasks.js | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 


applied series, squashed in a change to reduce the indentation level
though, thanks!