[pve-devel] [PATCH cluster/docs/manager/network/proxmox{, -ve-rs, -firewall, -perl-rs} 00/52] Add SDN Fabrics

[Gabriel Goller]

On 04.04.2025 12:55, Hannes Duerr wrote:
>On 3/28/25 18:12, Gabriel Goller wrote:
>>This series allows the user to add fabrics such as OpenFabric and OSPF over
>>their clusters.
>>
>>Overview
>>========
>>
>>This series allows the user to create routed networks ('fabrics') across their
>>clusters, which can be used as the underlay network for a EVPN cluster, or for
>>creating Ceph full mesh clusters easily.
>>
>>This patch series adds the initial support for two routing protocols:
>>* OpenFabric
>>* OSPF
>>
>>In the future we plan on moving the existing IS-IS and BGP controllers into the
>>fabric structure. There are also plans for adding a new Wireguard fabric to
>>this.
>Very nice feature and from my first impression it works really well!
>What I have noticed so far:
>1. if you remove interfaces from a node in OSPF you can't add them 
>later [snip]

Umm this is weird, I couldn't reproduce this... Do you get any error or
does the interface simply vanish. Does editing the node again (new
NodeEdit popup) fix the error or is the interface still gone?

> and if you remove the last one you get the following error:
>
>```
>Parameter verification failed. (400)
>*interfaces*: type check ('array') failed
>```
>which could be turned into a nicer message or even allowed (why can i 
>not remove all interfaces for maintenance reasons?).

In v2 we allow Nodes without interfaces, so this error shouldn't be
visible anymore.

>2. is there a use-case where i do not want to use an interface 
>`unnumbered` nor with an ip address?
>If you also can't think of any i'd suggest restricting it so that the 
>user has to either tick `unnumbered` or enter an ip address.
>I think this would help users starting with OSPF, configuring a node 
>and wondering why it is not working.

Yep, I just added this. Now you need to specific either unnumbered or an
ip address and specifying both will also lead to an error!

Thanks for the review!