[pve-devel] [PATCH installer] proxmox-chroot: replace nix::(u)mount calls with external (u)mount
Thomas Lamprecht
t.lamprecht at proxmox.com
Fri Apr 4 10:17:58 CEST 2025
Am 11.03.25 um 14:27 schrieb Christoph Heiss:
> Comes with a reduction of 52 -> 40 in terms of crate dependencies for
> proxmox-chroot, 198 -> 192 for a full workspace build.
>
> Currently, this is done inconsistently anyway, i.e. there are calls to
> the external mount(8) as well as mount(2) and umount(2) via `nix`.
> Just switch over to calling the external programs completely, which in
> turn allows to drop the `nix` crate dependency from the tree.
I'm general a big fan of dropping crates (or using as many as needed but
as few as possible), but nix is a very general thing, actually I'm
surprised we do not use it more often; maybe if we would write more of
the actual installer in rust. OTOH, nothing limits us from reintroducing
this, and then handle mounting in a more consistent manner implementation
wise - so fine by me...
More information about the pve-devel
mailing list