[pve-devel] applied: [PATCH container] api: autocomplete rootdir storages for create, move-volume and clone
Thomas Lamprecht
t.lamprecht at proxmox.com
Tue Sep 10 16:36:07 CEST 2024
Am 10/09/2024 um 13:23 schrieb Daniel Kral:
> Adds a helper subroutine for enumerating storages that are enabled and
> have the content type `rootdir` set, therefore supporting container
> directories.
>
> The autocompletion is added to the clone command and changed for the
> create and move-volume commands, which previously suggested any storage
> device. This is misleading as these commands will fail for any storage
> that is not configured to store container directories.
>
> Signed-off-by: Daniel Kral <d.kral at proxmox.com>
> ---
> I have already noticed that the create command has the default value
> 'local' for the storage parameter, which could fail on any installation
> where the local storage is not configured to store rootdirs. This should
> be fixed in a separate patch in my opinion.
good call
> src/PVE/API2/LXC.pm | 5 +++--
> src/PVE/LXC.pm | 14 ++++++++++++++
> 2 files changed, 17 insertions(+), 2 deletions(-)
>
>
applied, thanks!
More information about the pve-devel
mailing list