[pve-devel] [PATCH storage] base plugin: do not decode the empty string

Fiona Ebner f.ebner at proxmox.com
Tue Sep 10 11:52:59 CEST 2024


Am 02.09.24 um 14:47 schrieb Maximiliano Sandoval:
> If the json was empty, for example if the qemu-img command times out, a
> message
> 
>     warn "could not parse qemu-img info command output for '$filename' - $err\n";
> 
> would have been printed.
> 
> This message could lead one to think the issue lies in the contents of
> the json, even if the previous warning said that there was a timeout.
> 

I know it's already applied, so mentioning it for the future: the commit
title (and actually also message) really should've included the context,
e.g. "when querying file size".




More information about the pve-devel mailing list