[pve-devel] [PATCH common v4 3/7] inotify: interfaces: make sure bridge_vids use space as separator

Fiona Ebner f.ebner at proxmox.com
Tue Sep 10 11:37:26 CEST 2024


Am 29.07.24 um 13:55 schrieb Aaron Lauterer:
> Because the API accepts multiple possible list separators we need to
> make sure that we write the bridge_vids with space as separator, no
> matter which separator was used when passing it to the API.
> 

Nit: The reason why it's necessary to write out with space as the
separator is missing. Who gets confused otherwise ;)?

Should we do the conversion earlier, i.e. in the API endpoint when
writing the interface parameters? Like that we don't end up carrying the
invalid value around.

> Signed-off-by: Aaron Lauterer <a.lauterer at proxmox.com>
> Tested-By: Stefan Hanreich <s.hanreich at proxmox.com>
> Reviewed-by: Shannon Sterz <s.sterz at proxmox.com>

Still:

Reviewed-by: Fiona Ebner <f.ebner at proxmox.com>




More information about the pve-devel mailing list