[pve-devel] [RFC qemu-server] apt hook: warn against using 'upgrade' command

[Alexander Zeidler]

On Fri Sep 6, 2024 at 12:40 PM CEST, Fiona Ebner wrote:
> (DPkg::Pre-Invoke is also too late). Since this is just an additional
> safety warning to guide new users, it should still be good enough.

> +  if ($line && $line =~ m/^CommandLine::AsString=apt(-get)?%20upgrade$/) {
> +    $log->("!! WARNING !!\n");
> +    $log->("Using 'upgrade' can violate packaging assumptions made by Proxmox VE. Use 'dist-upgrade' instead.\n");
> +    $log->("\n");

As "an additional safety warning to guide new users", we may want to
rephrase this line:
> +    $log->("Press enter to continue, or C^c to abort.\n");
to something like:
"Press CTRL+C to abort, or ENTER to continue anyway."