[pve-devel] [PATCH manager v2] fix #5787: ui: add util function for guest confirmation dialog

[Thomas Lamprecht]

Am 29/10/2024 um 13:22 schrieb Christoph Heiss:
> The patch title implies that it only adds a utility function, but the
> patch itself also includes usage for it. Something like
> 
>   "fix #5787: ui: include guest name in confirmation dialog"
> 
> or similar would probably be a better fit.

Yes, that's basically what I suggested in my v1 review:

> fix #5787: ui: display guest name in confirm dialogs

-- https://lore.proxmox.com/pve-devel/87323348-4002-463b-9d6f-48db6eac6d8b@proxmox.com/

Please take advice seriously, it does not need to be followed 1:1, and
sometimes might have been even wrong, but in such a case one should comment
on why that was the case, either in the commit message if it's for a code or
design related or in the change section of a patch for meta ones like here.