[pve-devel] [PATCH manager 3/5] fix #5430: ui: vm: allow editing cdrom aio and cache options

Daniel Kral d.kral at proxmox.com
Wed Oct 23 13:30:13 CEST 2024


On 10/18/24 09:42, Lukas Wagner wrote:
>> @@ -125,7 +151,7 @@ Ext.define('PVE.qemu.CDInputPanel', {
>>   Ext.define('PVE.qemu.CDEdit', {
>>       extend: 'Proxmox.window.Edit',
>>   
>> -    width: 400,
>> +    width: 550,
> 
> This change is not mentioned in the commit message and should probably
> be split out into its own commit.

I added a small paragraph to the commit message, that makes that change 
more transparent and why it is needed in this commit, as the added 
options would be a bit messed up by the width limit ;).

Thanks for the style review! I've made the changes (including those in 
the other two replies) to the patch series and sent out a v2 [0].

[0] 
https://lore.proxmox.com/pve-devel/20241023112246.85637-1-d.kral@proxmox.com/




More information about the pve-devel mailing list