[pve-devel] [PATCH qemu] api: qemu: create: default cpu to x86-64-v2-AES

[Thomas Lamprecht]

Am 22/10/2024 um 13:23 schrieb Fiona Ebner:
> Am 01.10.24 um 16:08 schrieb Maximiliano Sandoval:
>> This makes it so newly created VMs, e.g. with `qm create` will have the
>> same default value as VMs created via the web UI.
>>
>> Signed-off-by: Maximiliano Sandoval <m.sandoval at proxmox.com>
>> ---
>> I am not entirely sure if there is side-effect that I am not taking into account.
>>
> This is a breaking change, because existing API callers now suddenly get
> a new default. Even if it were just CLI and not API, it would be
> breaking for the same reason (there are scripts using the CLI tools out
> there).
> 
> If we do this, then in a major release and prominently communicate it to
> all users in the release notes. And it should also be documented it in
> the API schema, that creation uses another default than the schema default.

And even then, would this still break restoring backups made before that
change?
If, this would fall under the changes that need versioning the guest
configs. Which naturally is possible but is IMO also not something I'd
do lightly, as that's something that might have wide-reaching consequences.