[pve-devel] applied: [PATCH v2 common] tools: file_set_contents: use syswrite instead of print

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Oct 14 11:22:12 CEST 2024


Am 14/10/2024 um 11:07 schrieb Dominik Csapak:
> hi since you applied this, we probably also want to apply the pmxcfs patch?

This is already an improvement on its own independent of where the destination
resides on, but yes, the pmxcfs one would have been the next to (re-)look more
closely at.

> (since without that, this patch does not really have an effect)
> 
> should i send a new version (as non rfc) with a better commit message for that
> or is that not necessary from your POV ?

Yes, please. It would be great if you could include some more background that
we learned since original submission and maybe some benchmarks directly, or at
least point to the one from Filip's commit.
But, as always, I'm a fan of keeping the essentials in the commit message
directly to make it more self-contained.






More information about the pve-devel mailing list