[pve-devel] [PATCH storage] iscsi: disable Open-iSCSI login retries to avoid blocking pvestatd

[Friedrich Weber]

Thanks for the test and review!

On 11/10/2024 13:20, Mira Limbeck wrote:
> [...]
>> --- a/src/PVE/Storage/ISCSIPlugin.pm
>> +++ b/src/PVE/Storage/ISCSIPlugin.pm
>> @@ -132,6 +132,14 @@ sub iscsi_login {
>>      eval { iscsi_discovery($portals); };
>>      warn $@ if $@;
>>  
>> +    # Disable retries to avoid blocking pvestatd for too long, next iteration will retry anyway
>> +    eval {
>> +	my $cmd = [$ISCSIADM, '--mode', 'node', '--targetname', $target, '--op', 'update',
>> +	    '--name', 'node.session.initial_login_retry_max', '--value', '0'];
> As shortly discussed off-list, this should probably follow a similar
> style as the `Wrapping Arguments` section in the Perl Style Guide, but
> grouping option and value together in the same line?
> https://pve.proxmox.com/wiki/Perl_Style_Guide#Wrapping_Arguments

Good point. I sent a v2 addressing this (and also rewording the commit
message, because I realized the v1 one was not really correct):

https://lore.proxmox.com/pve-devel/20241011125821.58224-1-f.weber@proxmox.com/