[pve-devel] applied: [PATCH http-server v2] fix #5391: proxy request: avoid HTTP 599 Too many redirections

[Thomas Lamprecht]

On 04/10/2024 11:43, Friedrich Weber wrote:
> The API server proxies HTTP requests in two cases:
> 
> - between cluster nodes (pveproxy->pveproxy)
> - between daemons on one node for protected API endpoints
>   (pveproxy->pvedaemon)
> 
> The API server uses AnyEvent::HTTP for proxying, with unfortunate
> settings for connection reuse (details below). With these settings,
> long-running synchronous API requests on the proxy destination's side
> can cause unrelated proxied requests to fail with a misleading HTTP
> 599 "Too many redirections" error response. In order to avoid these
> errors, improve the connection reuse settings.
> 

[...]

> 
> Suggested-by: Fabian Grünbichler <f.gruenbichler at proxmox.com>
> Signed-off-by: Friedrich Weber <f.weber at proxmox.com>
> ---
> 
> Notes:
>     Not sure if this particular benchmark is the best way to measure the
>     impact of this patch, if you have suggestions, please let me know.
>     
>     When applied, it might make sense to have this patch in its own
>     pve-http-server bump, so if users should notice significant
>     performance drops, they could go back to an earlier version to see if
>     this patch is responsible.
>     
>     v2:
>     - no code changes
>     - add benchmark to commit message
>     - fix typos in commit message
> 
>  src/PVE/APIServer/AnyEvent.pm | 19 ++++++++++++++-----
>  1 file changed, 14 insertions(+), 5 deletions(-)
> 
>

applied, many thanks for the detailed write-up and benchmarks, much appreciated,
thanks!