[PATCH SERIES v2] Add ability to prevent suggesting previously used VM/CT IDs

Severen Redwood severen.redwood at sitehost.co.nz
Fri Oct 4 07:07:39 CEST 2024


Hi everyone,

This patch series is an updated version of my previous series [1] adding
optional support for preventing PVE from suggesting previously used
VM/CT IDs.

The ID list is now read into a hash rather than an array so that O(1)
membership tests can be used when `/cluster/nextid` searches for the
next available ID. Consecutive sequences of IDs are also now written to
the disk as ranges to reduce the file size of the ID list. Finally, IDs
are now instead marked as used within the workers that handle deletion,
specifically just before the virtual machine or container's config file
is unlinked.

Thanks,
Severen

[1]: https://lore.proxmox.com/pve-devel/mailman.89.1727359009.332.pve-devel@lists.proxmox.com/T/#u

pve-manager
-----------
Severen Redwood (2):
  close #4369: api: optionally only suggest unique IDs
  close #4369: ui: add datacenter option for unique VM/CT IDs

 PVE/API2/Cluster.pm           | 13 +++++++++++--
 PVE/Makefile                  |  1 +
 PVE/UsedVmidList.pm           | 70 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 www/manager6/dc/OptionView.js |  4 ++++
 4 files changed, 86 insertions(+), 2 deletions(-)
 create mode 100644 PVE/UsedVmidList.pm

pve-container
-------------
Severen Redwood (1):
  api: record CT ID as used after a container is destroyed

 src/PVE/API2/LXC.pm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

qemu-server
-----------
Severen Redwood (1):
 api: record VM ID as used after a virtual machine is destroyed

  PVE/API2/Qemu.pm | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)

pve-cluster
-----------
Severen Redwood (2):
 cluster files: add used_vmids.list
 datacenter config: add unique-next-id to schema

 src/PVE/Cluster.pm          | 1 +
 src/PVE/DataCenterConfig.pm | 5 +++++
 src/pmxcfs/status.c         | 1 +
 3 files changed, 7 insertions(+)



More information about the pve-devel mailing list