[pve-devel] [PATCH manager] proxy: ui: vm console: autodetect novnc or xtermjs

[Aaron Lauterer]

sent a v2: 
https://lore.proxmox.com/pve-devel/20241125100427.86341-1-a.lauterer@proxmox.com/T/#u

On  2024-11-22  15:38, Aaron Lauterer wrote:
> Another thing that I noticed is that the property we use to decide if we
> enable xtermjs for VMs in the top right console button, and for now also
> in this patch, only checks if the VM has a serial device configured.
> PVE::QemuServer::vmstatus() calls `conf_has_serial()`.
> 
> A better approach would be to have a vmstatus property that actually
> tells us if the VM has serial set as display option. As the display
> could be set to something else, even if a serial device exists. There
> are other use-cases for a serial device in the VM, like passing through
> an actual serial port.
> 
> But I didn't want to open that can of worms just yet ;)