[pve-devel] applied: [PATCH manager v3] fix #5810: ui: show confirmation/warning dialog for sdn apply

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Nov 18 23:00:52 CET 2024


Am 12.11.24 um 13:02 schrieb Timothy Nicholson:
> Signed-off-by: Timothy Nicholson <t.nicholson at proxmox.com>
> ---
> 
> changes since v2 [0]:
> - changed icon
> - modified confirmation message
> 
> A conditional confirmation message would definitely be nicer, I can
> send a patch for that later on today as v4. 
> 
> [0]: https://lore.proxmox.com/pve-devel/20241104122457.95494-1-t.nicholson@proxmox.com/
> 
>  www/manager6/sdn/StatusView.js | 24 ++++++++++++++++--------
>  1 file changed, 16 insertions(+), 8 deletions(-)
> 
>

applied this one for now, it's way simpler and avoids O(n) api requests on
applying, which is quite much.

Note that I had to do with some small fixes for missing trailing commas
that eslint complained about, if you use `make install` inside www/manager
we do not enforce erroring out on warnings for convenience, but we do so
on building an actual debian package.




More information about the pve-devel mailing list