[pve-devel] applied: [PATCH manager v6 1/9] ui: fix special 'import' icon for non-esxi storages

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Nov 18 10:56:30 CET 2024


Am 18.11.24 um 09:47 schrieb Dominik Csapak:
> On 11/17/24 17:21, Thomas Lamprecht wrote:
>> albeit, for storages that just have the import content type defined it
>> would still show the icon until one then adds another content-type, so
>> could be still slightly confusing, but IMO it's and edge case we can
>> bother with if somebody really reports it.
> 
> actually IIRC this was intentional, so that 'import-only' storages stand
> out a bit, if you don't like it, i can change it ofc

I just find it odd that it can change due to some adaption of setting, like
if e.g. one adds a storage for just import first and then after a while also
allows managing ISOs/CT templates, but once that changed the previous
accustomed icon of that storage entry changes, and thus it might be harder
to spot, especially if one has a few other shared storage that share the
same icon.

For ESXi it was chosen because it's unlikely, close to completely impossible,
that we will ever expose that storage for something else, that's why it can
be fixated to a different icon. For file based storage that cannot be said.

IMO it might be nicer to show the available content types in some other form,
like small icons with tooltips for each enabled content type beside the name.

But for the short-term I do not see any pressing need to change that, but
maybe something to polish a bit during calmer times.






More information about the pve-devel mailing list