[pve-devel] partially-applied: [PATCH widget-toolkit v7 0/4] fix #3893: make bridge vids configurable

Aaron Lauterer a.lauterer at proxmox.com
Mon Nov 18 10:23:51 CET 2024



On  2024-11-16  16:41, Thomas Lamprecht wrote:
> Am 15.11.24 um 17:57 schrieb Aaron Lauterer:

> 
> 
> applied the widget toolkit with a few follow-ups to reduce code size and
> (try to) improve UX, maybe check them out to ensure nothing is off, thanks!

The UI changes, especially on the checks, seem to work as expected. Thanks!

> 
> The manager I also applied and adapted to my wtk changes, but FWICT you seem
> missing the backend validation for VIDs? So please add something similar to
> the UI checks there, if I did not overlook the checks happening in some other
> part of the call chain that is.

Those were all part of the earlier version and are already applied. 
Mainly in the register_format and accompanying validation function in 
pve-common.

https://git.proxmox.com/?p=pve-common.git;a=blobdiff;f=src/PVE/JSONSchema.pm;h=7c63af1c3f203944fb7e33fe3e1a5273c6f0361c;hp=ce390927b41894f3b681ec04beb73da571dae288;hb=0219596da20533e88c6638c593c66c302ad1218e;hpb=a8b8920d54595e2213292276e3cf77c0181fd894





More information about the pve-devel mailing list