[pve-devel] [PATCH pve-firewall v4 4/9] add support for loading sdn firewall configuration

[Stefan Hanreich]

On 11/17/24 15:57, Thomas Lamprecht wrote:
>> diff --git a/src/PVE/Service/pve_firewall.pm b/src/PVE/Service/pve_firewall.pm
>> index 65cb2b8..02b507a 100755
>> --- a/src/PVE/Service/pve_firewall.pm
>> +++ b/src/PVE/Service/pve_firewall.pm
>> @@ -158,7 +158,7 @@ __PACKAGE__->register_method ({
>>  
>>  	    PVE::Firewall::set_verbose(1); # show syntax errors
>>  
>> -	    my $cluster_conf = PVE::Firewall::load_clusterfw_conf(undef);
>> +	    my $cluster_conf = PVE::Firewall::load_clusterfw_conf();
> 
> just to be sure, above and below does not change anything, or?

yes. if the first parameter (= filename) is undef, then it loads the
config from the default path.

I'll look into incorporating the rest of your suggestions - thanks!