[pve-devel] applied: [PATCH installer] install: zfs: rename pre-existing `rpool` also if in degraded state

Thomas Lamprecht t.lamprecht at proxmox.com
Fri Nov 15 16:51:08 CET 2024


Am 15.11.24 um 16:35 schrieb Christian Ebner:
> If a subset of disks associated with a pre-existing ZFS pool are
> selected for installation, the pool might still be importable
> (required for the rename) but will be in a `degraded` state.
> Currently, only pools in `online` state will be considered for
> renameing, leading a possibly clashing pool named `rpool` behind.
> Therefore, a reboot after installation will fail because of the
> duplicate names.
> 
> To partially fix this behaviour, also rename `rpool` in `degraded`
> state.
> 
> Note:
> This however does not cover the case when a pool can no longer be
> imported because the number of required replicas is not available.
> Renaming by zpool import is not possible for that case.
> 
> Partially-fixes: 43591049 ("low-level: install: check for already-existing `rpool` on install")
> Signed-off-by: Christian Ebner <c.ebner at proxmox.com>
> ---
>  Proxmox/Install.pm | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
>

applied, thanks!




More information about the pve-devel mailing list