[pve-devel] [RFC PATCH installer 2/5] fix #5579: first-boot: add initial service packaging
Christoph Heiss
c.heiss at proxmox.com
Fri Nov 15 14:43:54 CET 2024
On Fri, Nov 15, 2024 at 02:39:16PM +0100, Thomas Lamprecht wrote:
> Am 15.11.24 um 14:34 schrieb Christoph Heiss:
> > On Thu, Nov 14, 2024 at 09:23:48PM +0100, Thomas Lamprecht wrote:
> >> [..]
> >> So it really would be great to allow overriding that ordering.
> >>
> >> Simplest way might be to leave it out here, or well go for the default we want
> >> (in doubt -> dice roll), and write out a systemd unit snippet during installation
> >> depending on a additional setting from the answer file.
> >
> > Thinking about this again, while implementing - if we need to customize
> > the unit file, do we want to:
> >
> > - create an `override.conf` file in
> > `/etc/systemd/system/proxmox-first-boot.service.d/`, like systemd
> > would do it when using `systemctl edit <service>`?
> > Disadvantage is, that that file isn't removed when removing the
> > `proxmox-first-boot` package from the system (although we could do it
> > via postrm maybe?)
>
> I'd either use above or as an additional alternative: ship the different
> variants as separate complete unit files with a common Alias (to convey
> that they're the "same" thing) and enable only the one (manually) that is
> configured. That would keep every file fully covered by the package
> system.
Didn't think of that variant, good idea! Thanks!
Should really cover all the cases I think and leave no files unmanaged.
(Also, TIL about Alias=)
More information about the pve-devel
mailing list