[pve-devel] [PATCH storage v5 02/12] plugin: dir: implement import content type

Dominik Csapak d.csapak at proxmox.com
Fri Nov 15 12:44:27 CET 2024


On 11/15/24 12:24, Fiona Ebner wrote:
> On 15.11.24 12:16 PM, Fiona Ebner wrote:
>> On 14.11.24 10:32 AM, Dominik Csapak wrote:
>>> +
>>> +    my ($vtype, $name, undef, undef, undef, undef, $fmt) = $class->parse_volname($volname);
>>> +    die "invalid content type '$vtype'\n" if $vtype ne 'import';
>>> +    die "invalid format\n" if $fmt ne 'ova' && $fmt ne 'ovf';
>>
>> The $IMPORT_EXT_RE_1 regex doesn't include 'ova' anymore. Is it still
>> wanted here?
> 
> Okay, I guess strictly speaking it would go into the next patch ;)

ah ok, this probably happened on some rebase

since i probably have to send a v6 anyway, i'd move the ova check
in the next patch that includes ova in the IMPORT_EXT_RE_1 ?




More information about the pve-devel mailing list