[pve-devel] applied: [PATCH manager] ui: tree: show tooltips for all entries that have sensible information

Dominik Csapak d.csapak at proxmox.com
Fri Nov 15 07:37:47 CET 2024


On 11/14/24 19:09, Thomas Lamprecht wrote:
> Am 14.11.24 um 09:04 schrieb Dominik Csapak:
>> instead of filtering pools and groups out manually, simply accumulate
>> the info we want to to have (status/hastate/etc.) and if any of those
>> exist, show the tooltip.
>>
>> This results in the nodes also having a tooltip, including their hastate
>> (such as online/maintenance), and automatically would show such things
>> in the future if we add those fields to other entries.
>>
>> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
>> ---
>>   www/manager6/tree/ResourceTree.js | 11 +++++++----
>>   1 file changed, 7 insertions(+), 4 deletions(-)
>>
>>
> 
> applied, thanks!
> 
> One minor thing I noticed, and where I'm rather unsure if we should do
> anything about it, is some potential odd interaction between the tooltip
> and the context menu, e.g. if I open the context menu of a node and then
> move the cursor up to the node icon the tooltip pops up and is displayed
> over the context menu and needs relatively long to hide.
> But FWICT this was always the case for guests already anyway, so probably
> it's just me overthinking this.

Yeah I also think this was always the case, and IMHO it's not a huge issue.
If we want to change that behavior, I'd suggest we disable the tree
tooltips completely as long as a context menu is shown, but this
can also be done later.




More information about the pve-devel mailing list