[pve-devel] applied: [PATCH installer v3 0/2] assistant: clean up glob patterns & regexes

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Nov 14 20:53:09 CET 2024


Am 14.11.24 um 15:15 schrieb Christoph Heiss:
> The proxmox-auto-install-assistant uses regexes for udev property
> matching, which can be simplified by some simple prefix matching and
> splitting on '='.
> 
> The latter also significantly reduces binary size (-46%) due to the
> removing the regex dependency, for details see patch #2.
> 
> Overall no functional changes in this series.
> 
> history
> =======
> 
> v2: https://lore.proxmox.com/pve-devel/20240513094936.412650-1-c.heiss@proxmox.com/
> v1: https://lists.proxmox.com/pipermail/pve-devel/2024-May/063802.html
> 
> Changes v2 -> v3:
>   * rebased on latest master, dropping applied & obsolete patches
> 
> Changes v1 -> v2:
>   * rebased on latest master
> 
> Christoph Heiss (2):
>   tree-wide: run rustfmt, fix clippy warnings
>   assistant: avoid regex for simple prefix matching
> 
>  proxmox-auto-install-assistant/src/main.rs   | 61 +++++++++-----------
>  proxmox-auto-installer/tests/parse-answer.rs |  2 +-
>  proxmox-installer-common/src/setup.rs        |  5 +-
>  proxmox-tui-installer/src/views/mod.rs       |  2 +-
>  4 files changed, 32 insertions(+), 38 deletions(-)
> 

applied both patches, thanks!




More information about the pve-devel mailing list