[pve-devel] applied: [PATCH common v4 05/27] test: lock file: get rid of END block that made test always pass

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Nov 14 20:46:05 CET 2024


Am 14.11.24 um 16:07 schrieb Fiona Ebner:
> The exit code of the test would be the exit code of the 'rm' system
> call, no matter if the test itself failed or not. Use an eval block
> instead of the END block and propagate the error correctly.
> 
> Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>
> ---
> 
> New in v4.
> 
> Diff is better viewed with
> --color-moved=zebra --color-moved-ws=ignore-all-space
> 
>  test/lock_file.pl | 90 +++++++++++++++++++++++++----------------------
>  1 file changed, 47 insertions(+), 43 deletions(-)
> 
>

applied, thanks!




More information about the pve-devel mailing list