[pve-devel] applied: [PATCH v2 storage 1/1] file_size_info: implement untrusted mode
Thomas Lamprecht
t.lamprecht at proxmox.com
Thu Nov 14 19:14:13 CET 2024
Am 04.11.24 um 11:42 schrieb Fabian Grünbichler:
> this allows checking some extra attributes for images which come from a
> potentially malicious source.
>
> since file_size_info is not part of the plugin API, no API bump is needed. if
> desired, a similar check could also be implemented in volume_size_info, which
> would entail bumping both APIVER and APIAGE (since the additional parameter
> would make checking untrusted volumes opt-in for external plugins).
>
> Signed-off-by: Fabian Grünbichler <f.gruenbichler at proxmox.com>
> Reviewed-by: Fiona Ebner <f.ebner at proxmox.com>
> ---
>
> Notes:
> v2: adapt to new early return, add Fiona's R-b
>
> src/PVE/Storage.pm | 4 ++--
> src/PVE/Storage/Plugin.pm | 36 +++++++++++++++++++++++++++++++-----
> 2 files changed, 33 insertions(+), 7 deletions(-)
>
>
applied, with Fiona's and Dominik's review trailers, thanks!
More information about the pve-devel
mailing list