[pve-devel] applied: [PATCH manager v3] ui: acme: switch cluster view items over to those from widget-toolkit

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Nov 13 15:36:43 CET 2024


Am 13.11.24 um 14:26 schrieb Filip Schauer:
> The pmxACMEAccountView & pmxACMEPluginView in proxmox-widget-toolkit
> were copied from pve-manager in commits 5df894de and 658bfdff. This
> makes pveACMEAccountView & pveACMEPluginView redundant, hence remove
> them and use pmxACMEAccountView & pmxACMEPluginView instead.
> 
> This leaves PVE.node.ACMEAccountView & pveACMEPluginEditor unused, so
> remove them too.
> 
> Signed-off-by: Filip Schauer <f.schauer at proxmox.com>
> ---
> Changes since v2:
> * In pveACMEClusterView correct the xtype of the first item
>   (pmxACMEAccountView -> pmxACMEAccounts)
> 
> Changes since v1:
> * Also switch over account view
> * Correct acmeUrl (/config/acme -> /cluster/acme)
> * Reference introduction of pmxACMEAccountView & pmxACMEPluginView in
>   commit message
> * Remove ACMEPluginEdit.js from the Makefile
> 
>  www/manager6/Makefile              |   1 -
>  www/manager6/dc/ACMEClusterView.js | 204 +-------------------------
>  www/manager6/dc/ACMEPluginEdit.js  | 223 -----------------------------
>  www/manager6/node/ACME.js          |  66 ---------
>  4 files changed, 4 insertions(+), 490 deletions(-)
>  delete mode 100644 www/manager6/dc/ACMEPluginEdit.js
> 
>

applied, thanks!




More information about the pve-devel mailing list